Skip to content

Bring MagpieTTS Release Fixes into Main Branch#15882

Merged
subhankar-ghosh merged 4 commits into
NVIDIA-NeMo:mainfrom
blisc:main
Jul 15, 2026
Merged

Bring MagpieTTS Release Fixes into Main Branch#15882
subhankar-ghosh merged 4 commits into
NVIDIA-NeMo:mainfrom
blisc:main

Conversation

@blisc

@blisc blisc commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do ?

Add fix for inference parameters, and fix for multiple G2P dictionaries for MagpieTTS release.

Collection: tts

Changelog

  • Change inference parameters for MagpieTTS to cover more parameters
  • Add fix for use of multiple G2P dicts
  • Move inference magic numbers to inference parameters

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@copy-pr-bot

copy-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the TTS label Jul 7, 2026
Signed-off-by: Jason <jasoli@nvidia.com>
Comment thread tests/collections/tts/models/test_magpietts_tokenizer_artifacts.py Fixed
Signed-off-by: Jason <jasoli@nvidia.com>
@blisc

blisc commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 993adec

@blisc
blisc requested a review from subhankar-ghosh July 7, 2026 16:35
Signed-off-by: Jason <jasoli@nvidia.com>
@blisc

blisc commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 68eec71

Signed-off-by: Jason <jasoli@nvidia.com>
@blisc

blisc commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 3685fb1

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[🤖]: Hi @blisc 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

@subhankar-ghosh
subhankar-ghosh enabled auto-merge (squash) July 15, 2026 01:16

@subhankar-ghosh subhankar-ghosh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@subhankar-ghosh
subhankar-ghosh merged commit 24c4f58 into NVIDIA-NeMo:main Jul 15, 2026
174 of 178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants